Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #580: change k3s to /usr/local/bin/k3s #202

Closed
wants to merge 1 commit into from
Closed

Fixes #580: change k3s to /usr/local/bin/k3s #202

wants to merge 1 commit into from

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Dec 15, 2022

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#580

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

I have made a package and move it to a new machine which PATH doesn't include /usr/local/bin. Manual installation of karavi-authorization with the package was performed successfully.

@csmbot
Copy link
Collaborator

csmbot commented Dec 15, 2022

Can one of the admins verify this patch?

@@ -13,9 +13,10 @@

set -x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the debugging option ?

@sharmilarama
Copy link
Collaborator

run e2e test

@xuluna xuluna closed this Dec 15, 2022
@xuluna xuluna deleted the KRV-10126 branch December 15, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants