-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flag to skip selinux download #187
Conversation
run e2e test |
Can we provide the option for customers to override this environment variable in case they want to download the K3s SELinux RPM during the install? For example, By default we can skip it, but would be good to also allows overriding of this parameter. |
We will need to read it in from somewhere during rpm install, the config.json file is probably the only option to enable that from. FYI this download was always disabled, just the flag has changed. We can keep this existing behavior for now and address the override option as a future enhancement. |
run e2e test |
8390503
run e2e test |
Description
There was an issue while installing karavi-authorization-1.4-0.x86_64.rpm, the k3s would fail to install, which is caused by trying to install k3s-selinux unsuccessfully. By adding this flag, the installation would skip the installation of k3s-selinux.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Verified using E2E test
Logs:
Verifying... ########################################
Preparing... ########################################
Updating / installing...
karavi-authorization-1.4-0 ########################################
Installing karavi-authorization-1.4.0
Using config file: /root/.karavi/config.json
Extracting files...Done!
Installing karavictl into /usr/local/bin...Done!
Installing Karavi-Authorization...Done!
Copying the Karavi-Authorization sidecar proxy image locally...Done!