Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flag to skip selinux download #187

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Adding flag to skip selinux download #187

merged 2 commits into from
Sep 2, 2022

Conversation

bjiang27
Copy link
Contributor

@bjiang27 bjiang27 commented Sep 2, 2022

Description

There was an issue while installing karavi-authorization-1.4-0.x86_64.rpm, the k3s would fail to install, which is caused by trying to install k3s-selinux unsuccessfully. By adding this flag, the installation would skip the installation of k3s-selinux.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#461

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Verified using E2E test

Logs:
Verifying... ########################################
Preparing... ########################################
Updating / installing...
karavi-authorization-1.4-0 ########################################
Installing karavi-authorization-1.4.0
Using config file: /root/.karavi/config.json
Extracting files...Done!
Installing karavictl into /usr/local/bin...Done!
Installing Karavi-Authorization...Done!
Copying the Karavi-Authorization sidecar proxy image locally...Done!

sharmilarama
sharmilarama previously approved these changes Sep 2, 2022
@bjiang27
Copy link
Contributor Author

bjiang27 commented Sep 2, 2022

run e2e test

@tdawe
Copy link
Collaborator

tdawe commented Sep 2, 2022

Can we provide the option for customers to override this environment variable in case they want to download the K3s SELinux RPM during the install? For example, INSTALL_K3S_SKIP_SELINUX_RPM=false rpm -i karavi-authorization.rpm

By default we can skip it, but would be good to also allows overriding of this parameter.

@sharmilarama
Copy link
Collaborator

sharmilarama commented Sep 2, 2022

Can we provide the option for customers to override this environment variable in case they want to download the K3s SELinux RPM during the install? For example, INSTALL_K3S_SKIP_SELINUX_RPM=false rpm -i karavi-authorization.rpm

By default we can skip it, but would be good to also allows overriding of this parameter.

We will need to read it in from somewhere during rpm install, the config.json file is probably the only option to enable that from. FYI this download was always disabled, just the flag has changed. We can keep this existing behavior for now and address the override option as a future enhancement.

@bjiang27
Copy link
Contributor Author

bjiang27 commented Sep 2, 2022

run e2e test

@bjiang27
Copy link
Contributor Author

bjiang27 commented Sep 2, 2022

run e2e test

@bjiang27 bjiang27 merged commit c458988 into main Sep 2, 2022
@bjiang27 bjiang27 deleted the k3s-fix branch September 3, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants