Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing unit test and gosec false alarm #149

Merged
merged 1 commit into from
Nov 4, 2021
Merged

fixing unit test and gosec false alarm #149

merged 1 commit into from
Nov 4, 2021

Conversation

hoppea2
Copy link
Collaborator

@hoppea2 hoppea2 commented Nov 4, 2021

Description

Fixed a unit test where the expected outcome was not predictable.
Fix gosec issue by renaming parameter and excluding false positive alerts

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#89

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@hoppea2 hoppea2 merged commit 4549b8a into main Nov 4, 2021
@hoppea2 hoppea2 deleted the fix-unit-test branch March 16, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants