[feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atye
changed the title
atye
requested review from
gallacher,
tdawe,
alikdell,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong,
forrestxia,
nitesh3108,
rajendraindukuri,
shefali-malhotra,
panigs7,
chimanjain and
HarishH-DELL
as code owners
5 tasks
atye
changed the title
atye
changed the title
5 tasks
atye
force-pushed
the
authorization-ingress-fix
branch
from
b462bdb to
df6423f
Compare
xuluna
previously approved these changes
Jan 30, 2024
shaynafinocchiaro
previously approved these changes
Jan 30, 2024
alikdell
reviewed
Jan 30, 2024
| name: csm-authorization-redis | ||
| spec: | ||
| capacity: | ||
| storage: 8Gi |
There was a problem hiding this comment.
Probably not but I think it's ok to allow this space. This is what has been configured since the beginning of Authorization.
shaynafinocchiaro
approved these changes
Jan 30, 2024
EmilyKatdell
approved these changes
Jan 31, 2024
PeresKereotubo
approved these changes
Jan 31, 2024
EvgenyUglov
approved these changes
Jan 31, 2024
atye
force-pushed
the
authorization-ingress-fix
branch
from
7f94b88 to
0fee826
Compare
alikdell
approved these changes
Jan 31, 2024
rishabhatdell
pushed a commit
that referenced
this pull request
Mar 20, 2024
… storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment
rishabhatdell
pushed a commit
that referenced
this pull request
Mar 20, 2024
… storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment
HarishH-DELL
added a commit
that referenced
this pull request
Mar 20, 2024
* Release v1.9.1 (#364) * Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354) * Update cosi image in chart (#359) * revert kube node name changes (#361) * Removing csm changes (#363) --------- Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> * Update Chart.yaml (#365) * update helm releaser (#366) * update csm chart for v2.9.1 (#369) * Release v1.9.3 (#376) * CSM 1.9.3 * csm version bump (#375) * Update Chart.yaml (#379) --------- Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update Chart.yaml with new versions (#380) * added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * app mobility version fix * Update app mobility Chart --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]>
3 tasks
HarishH-DELL
added a commit
that referenced
this pull request
Mar 20, 2024
* Conflict fix verified (#388) * Release v1.9.1 (#364) * Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354) * Update cosi image in chart (#359) * revert kube node name changes (#361) * Removing csm changes (#363) --------- Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> * Update Chart.yaml (#365) * update helm releaser (#366) * update csm chart for v2.9.1 (#369) * Release v1.9.3 (#376) * CSM 1.9.3 * csm version bump (#375) * Update Chart.yaml (#379) --------- Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update Chart.yaml with new versions (#380) * added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * app mobility version fix * Update app mobility Chart --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> * AM version reverted --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]>
hoppea2
added a commit
that referenced
this pull request
Mar 20, 2024
* Release v1.9.1 (#364) * Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354) * Update cosi image in chart (#359) * revert kube node name changes (#361) * Removing csm changes (#363) --------- Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> * Update Chart.yaml (#365) * update helm releaser (#366) * update csm chart for v2.9.1 (#369) * Release v1.9.3 (#376) * CSM 1.9.3 * csm version bump (#375) * Update Chart.yaml (#379) --------- Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update Chart.yaml with new versions (#380) * added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * app mobility version fix * Update app mobility Chart --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: HarishH-DELL <[email protected]>
hoppea2
added a commit
that referenced
this pull request
Mar 20, 2024
* added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * app mobility version fix * Update app mobility Chart * Conflict fix verified (#388) (#389) * Conflict fix verified (#388) * Release v1.9.1 (#364) * Disable leader-election for drivers and version bump up for csm 1.9.1 patch release (#354) * Update cosi image in chart (#359) * revert kube node name changes (#361) * Removing csm changes (#363) --------- Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> * Update Chart.yaml (#365) * update helm releaser (#366) * update csm chart for v2.9.1 (#369) * Release v1.9.3 (#376) * CSM 1.9.3 * csm version bump (#375) * Update Chart.yaml (#379) --------- Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> * Update Chart.yaml with new versions (#380) * added env for kube node name (#347) * Driver and Modules Version Update (#348) * Updating helm charts to support k8s 1.29.0 (#358) * Disabling leader election for v1.10.0 (#360) * [feature-1091]: Expose proxy-server via cluster node IP and use local storage for Redis by default (#353) * expose proxy-server by ip address of master node * fix spacing * use local pv for redis by default * remove period * recycle pv * update authorization.hostname comment * Bumping reverseproxy version (#371) * COSI driver verion bump up (#370) * CSI-Sidecars version bumpup (#372) * CSI-Sidecars version bumpup * Snapshotter patch version update * Mapping /opt/emc inside SDC container (#373) * Mapping /opt/emc inside SDC container * Updating path type * app mobility version bump (#374) * change default value (#381) * version bumps (#378) * Updated CSI Metadata Version (#382) * app mobility version fix * Update app mobility Chart --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> * AM version reverted --------- Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]> Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> * Reverted the CSM file to main (#390) * Reverted changes * Reverted the space --------- Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: hoppea2 <[email protected]> Co-authored-by: Adarsh Kumar Yadav <[email protected]> Co-authored-by: Aaron Tye <[email protected]> Co-authored-by: boyamurthy <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: KerryKovacevic <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Bartosz Ciesielczyk <[email protected]> Co-authored-by: KshitijaKakde <[email protected]> Co-authored-by: Jooseppi Luna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
It enables access to the proxy-server by the IP address of the cluster master node instead of requiring access by one of the hostnames configured in the Ingress.
This also configures a local provisioner for Redis to use by default so the user does not have to worry about what storage class to use for Redis. They can still provide a storage class if they wish.
Which issue(s) is this PR associated with:
dell/csm#1091
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable