Use helm chart for dependencies to fix packaging issues #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdawe
requested review from
gallacher,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
taohe1012,
P-Cao,
baoy1,
YianZong and
forrestxia
as code owners
|
@tdawe should this be merged in the release-v1.7.0 branch? The *-wizard branch is not tracking all the changes for the 1.7 release. |
This will be required in a separate release branch specifically for the container-storage-modules helm chart so that we can properly reference the dependencies and package those sub-dependencies (ex: Velero and Cert-Manager dependencies). |
sharmilarama
approved these changes
Mar 28, 2023
alikdell
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
Fixes packaging of dependencies by refering to our official helm chart repository
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable