Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable authorization for csm observability powerscale #135

Merged

Conversation

taohe1012
Copy link
Contributor

@taohe1012 taohe1012 commented Aug 8, 2022

Is this a new chart?

No

What this PR does / why we need it:

enable authorization for csm observability powerscale

Which issue(s) is this PR associated with:

Special notes for your reviewer:

To enable authorization for csm observability powerscale, and To keep compatibility with authorization of csm observability powerflex, please run below commands to copy/rename configmap and secrets from isilon namespace to karavi namespace:

  1. kubectl get configmap isilon-config-params -n isilon -o yaml | sed 's/namespace: isilon/namespace: karavi/' | kubectl create -f -
  2. kubectl get secret karavi-authorization-config proxy-server-root-certificate proxy-authz-tokens -n isilon -o yaml | sed 's/namespace: isilon/namespace: karavi/' | sed 's/name: karavi-authorization-config/name: isilon-karavi-authorization-config/' | sed 's/name: proxy-server-root-certificate/name: isilon-proxy-server-root-certificate/' | sed 's/name: proxy-authz-tokens/name: isilon-proxy-authz-tokens/' | kubectl create -f -

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

forrestxia
forrestxia previously approved these changes Aug 8, 2022
env:
- name: PROXY_HOST
value: "{{ .Values.karaviMetricsPowerscale.authorization.proxyHost }}"
- name: INSECURE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update INSECURE to SKIP_CERTIFICATE_VALIDATION to align with the new Authorization sidecar proxy nomenclature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaynafinocchiaro updated powerflex and powerscale.
and what version sidecar can I used for testing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the nightly tag for testing purposes

@taohe1012 taohe1012 force-pushed the feature-413-csm_pscale_authorization branch from e5d7c33 to c9ed10d Compare August 8, 2022 13:51
@taohe1012 taohe1012 merged commit 481a746 into karavi-observability-release Aug 12, 2022
@taohe1012 taohe1012 deleted the feature-413-csm_pscale_authorization branch August 12, 2022 02:43
forrestxia added a commit that referenced this pull request Sep 21, 2022
* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <[email protected]>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <[email protected]>

Co-authored-by: hoppea2 <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Co-authored-by: Sharmila Ramamoorthy <[email protected]>
Co-authored-by: YianZong <[email protected]>
Co-authored-by: taohe1012 <[email protected]>
Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>
Co-authored-by: baoy1 <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Co-authored-by: bjiang27 <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
forrestxia added a commit that referenced this pull request Sep 21, 2022
…148)

* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <[email protected]>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <[email protected]>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

Co-authored-by: hoppea2 <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Co-authored-by: Sharmila Ramamoorthy <[email protected]>
Co-authored-by: YianZong <[email protected]>
Co-authored-by: taohe1012 <[email protected]>
Co-authored-by: forrestxia <[email protected]>
Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Co-authored-by: bjiang27 <[email protected]>
atye added a commit that referenced this pull request Dec 13, 2022
* changes for 1.4.0 (#145) (#146)

* charts/karavi-observability: Version fix for csm-metrics-powerscale (#148)

* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <[email protected]>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <[email protected]>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

Co-authored-by: hoppea2 <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Co-authored-by: Sharmila Ramamoorthy <[email protected]>
Co-authored-by: YianZong <[email protected]>
Co-authored-by: taohe1012 <[email protected]>
Co-authored-by: forrestxia <[email protected]>
Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Co-authored-by: bjiang27 <[email protected]>

* [charts/csm-application-mobility]: Application Mobility v0.2.0 Release (#159)

* update authorization chart and image versions (#155)

Co-authored-by: baoy1 <[email protected]>
Co-authored-by: hoppea2 <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Co-authored-by: Sharmila Ramamoorthy <[email protected]>
Co-authored-by: YianZong <[email protected]>
Co-authored-by: taohe1012 <[email protected]>
Co-authored-by: forrestxia <[email protected]>
Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Co-authored-by: bjiang27 <[email protected]>
Co-authored-by: Trevor Dawe <[email protected]>
sharmilarama added a commit that referenced this pull request Dec 13, 2022
* Update otel-collector-config.yaml

updated tls settings for otel

* Update Chart.yaml

increment helm chart version

* Update otel-collector-config.yaml

updating correct tls settings

* Update otel-collector-config.yaml

update tls settings

* update observability metric service immage taags for CSM .3 release (#124)

* align authorization sidecar with CSM 1.3 release (#126)

* add support for PowerScale topology (#123)

* Rollback otel-collecter image version to 0.42.0 (#131)

* Update code owners list (#132)

* Add more code owners

* chart/csm-authorization: Release v1.3.0 updates (#128)

* [charts/csm-authorization] feature-261: Authorization helm chart (#109)
* use 1.3.0 (#125)

Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

Co-authored-by: sharmilarama <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>

* Correct codeowners format (#133)

* add support for csm-metrics-powerscale (#129)

Add powerscale configuration to support csm-metrics-powerscale:
  - Add karavi-metrics-powerscale.yaml, karavi-metrics-powerscale.yaml;
  - Add pscale configuration to karavi-observability-configmap.yaml,
  values.yaml, cert-manager.yaml and NOTES.txt.

* Adjust PowerScale polling enable and frequency (#134)

The new enable and frequency are:
capacityMetricsEnabled: "true"
performanceMetricsEnabled: "true"
clusterCapacityPollFrequencySeconds: 30
clusterPerformancePollFrequencySeconds: 20
quotaCapacityPollFrequencySeconds: 30

Co-authored-by: Yiming Bao <[email protected]>

* enable authorization for csm observability powerscale (#135)

* Update Authorization sidecar image to 1.4.0 (#138)

* Update observability image tags for CSM 1.4 release (#142)

Co-authored-by: Yiming Bao <[email protected]>

* Update csm-metrics-powerscale to 1.0.0 (#147)

Update csm-metrics-powerscale to 1.0.0 to accommodate csm-metrics-powerscale release

* Update cert-manager to 1.10.0 for Observability (#151)

* update authorization sidecar image (#156)

* Update to latest images

Co-authored-by: hoppea2 <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Co-authored-by: YianZong <[email protected]>
Co-authored-by: taohe1012 <[email protected]>
Co-authored-by: forrestxia <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: EvgenyUglov <[email protected]>
Co-authored-by: baoy1 <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Co-authored-by: bjiang27 <[email protected]>
Co-authored-by: Yiming Bao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants