Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCG Snapshot Force Error #145

Merged
merged 1 commit into from
Nov 7, 2024
Merged

RCG Snapshot Force Error #145

merged 1 commit into from
Nov 7, 2024

Conversation

doriac11
Copy link
Collaborator

@doriac11 doriac11 commented Nov 5, 2024 •
edited
Loading

Description

  • When doing a Create RCG Snapshot, there is no force value in the body of the request. If force is included on POST request it ends in an error and does not create the snapshot.

Error if force body is sent

image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test

Test output

image

@doriac11 doriac11 force-pushed the fix-rcg-snapshot-create branch from e9b7b2d to 6336185 Compare November 5, 2024 13:56
@doriac11
RCG Snapshot Force Error
c895c87 
- When doing a Create RCG Snapshot, there is no force value in the body
  of the request. If force is included on  POST request it ends in an
  error and does not create the snapshot.
@doriac11 doriac11 force-pushed the fix-rcg-snapshot-create branch from 6336185 to c895c87 Compare November 6, 2024 12:41
@baoy1 baoy1 self-requested a review November 7, 2024 07:30
@doriac11 doriac11 merged commit a20c253 into main Nov 7, 2024
4 checks passed
@doriac11 doriac11 deleted the fix-rcg-snapshot-create branch November 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaiasA1 IsaiasA1 IsaiasA1 approved these changes

@baoy1 baoy1 baoy1 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@ashleyvjoy ashleyvjoy Awaiting requested review from ashleyvjoy ashleyvjoy is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell rishabhatdell is a code owner

@sakshi-garg1 sakshi-garg1 Awaiting requested review from sakshi-garg1 sakshi-garg1 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doriac11 @baoy1 @IsaiasA1