Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMe host APIs #132

Merged
merged 1 commit into from
Sep 29, 2024
Merged

NVMe host APIs #132

merged 1 commit into from
Sep 29, 2024

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Sep 25, 2024

Description

  • Support NVMe host management, e.g. Get, Rename, Change MaxNumPaths, Change MaxNumSysPorts and delete NVMe host
  • Correctly suppress gosec error G402 (CWE-295)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • UT
    goscaleio_ut

  • IT
    goscaleio_it

  • Code coverage
    goscaleio_code_coverage

nvme_host.go Show resolved Hide resolved
- Support Get, Rename, Change MaxNumPaths, Change MaxNumSysPorts and
  delete NVMe host
- Correctly suppress gosec error G402 (CWE-295)
@baoy1 baoy1 merged commit 0d4ba30 into main Sep 29, 2024
4 checks passed
@baoy1 baoy1 deleted the nvme_host branch October 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants