Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golagnci lint warnings #110

Merged
merged 25 commits into from
Apr 26, 2024
Merged

Fix golagnci lint warnings #110

merged 25 commits into from
Apr 26, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Apr 25, 2024 •
edited
Loading

Description

Fix golangci lint warnings

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@AkshaySainiDell
Update workflows to allow manual trigger
6a78834
@AkshaySainiDell
Fix gofumpt warnings
bc619c8
@AkshaySainiDell
Fix gofumpt warnings
45652b7
@AkshaySainiDell
Fix golangci-lint warnings in api package
8e34bd1
@AkshaySainiDell
Fix golangci-lint warning in inttests package
628e043
@AkshaySainiDell
Fix golangci-lint warnings in types dir
1676549
@AkshaySainiDell
Fix golangci-lint warnings in fs related files
7620cdd
@AkshaySainiDell
Fix golangci-lint warnings in api and deploy
15dd57e
@AkshaySainiDell
Fix golangci-lint warnings in device and fault_set
a26855a
@AkshaySainiDell
Fix golangci-lint warnings in sdc and sds
14c7cdf
@AkshaySainiDell
Fix golangci-lint warnings in snapshot_policy and storagepool
2075970
@AkshaySainiDell
Fix golangci-lint warnings in node and replication
d54e68e
@AkshaySainiDell
Fix golangci-lint warnings in service
da786da
@AkshaySainiDell
Fix golangci-lint warnings in sso_user_test
4b73d43
@AkshaySainiDell
Fix golangci-lint warnings in system_limit_test
ec74820
@AkshaySainiDell
Fix golangci-lint warnings in system_test
5a0b9e1
@AkshaySainiDell
Fix golangci-lint warnings in template
f60d2bd
@AkshaySainiDell
Fix golangci-lint warnings in tree_quota_test
e447147
@AkshaySainiDell
Fix golangci-lint warnings in tree_quota_test
e02b53e
@AkshaySainiDell
Fix golangci-lint warnings in user
7f06a0e
@AkshaySainiDell
Fix golangci-lint warnings in volume and vtree
52a8d64
@AkshaySainiDell AkshaySainiDell changed the title Fix golanci lint warnings Fix golagnci lint warnings Apr 25, 2024
@shenda1
Copy link
Collaborator

shenda1 commented Apr 25, 2024

Is it possible to upload test results?

@alikdell alikdell merged commit 9138a73 into main Apr 26, 2024
4 checks passed
@shanmydell shanmydell deleted the fix-golanci-lint-warnings branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@alikdell alikdell alikdell approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@AnikaAgiwal2711 AnikaAgiwal2711 Awaiting requested review from AnikaAgiwal2711

@Krunal-Thakkar Krunal-Thakkar Awaiting requested review from Krunal-Thakkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkshaySainiDell @shenda1 @alikdell @suryagupta4