Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sso user functionalities for 4.5 #100

Merged
merged 5 commits into from
Feb 27, 2024
Merged

adding sso user functionalities for 4.5 #100

merged 5 commits into from
Feb 27, 2024

Conversation

shenda1
Copy link
Collaborator

@shenda1 shenda1 commented Feb 22, 2024

Description

PR is raised to add SSO user functionalities for 4.5

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

image

image

@alikdell
Copy link
Contributor

Please fix linting and format issues in PR

@shenda1 shenda1 requested a review from adarsh-dell February 27, 2024 05:07
@shenda1
Copy link
Collaborator Author

shenda1 commented Feb 27, 2024

Please fix linting and format issues in PR

@alikdell We had a discussion with Sean on this. Will address these issues in the upcoming release. We have created internal JIRA ticket to track this. Thanks.

@shenda1 shenda1 merged commit c20e91b into main Feb 27, 2024
1 of 4 checks passed
@shanmydell shanmydell deleted the sso_user branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants