Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove omitEmpty from failover param #123

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Remove omitEmpty from failover param #123

merged 1 commit into from
Jan 31, 2024

Conversation

delldubey
Copy link
Contributor

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1109

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

  • Removing omitEmpty from Failover Param as it was getting removed if it was false

@delldubey delldubey merged commit d82b09b into main Jan 31, 2024
4 checks passed
@shanmydell shanmydell deleted the omitempty_debug branch January 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerryKovacevic KerryKovacevic KerryKovacevic approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@gilltaran gilltaran Awaiting requested review from gilltaran

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10

@shanmydell shanmydell Awaiting requested review from shanmydell

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@tssushma tssushma Awaiting requested review from tssushma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delldubey @boyamurthy @KerryKovacevic