Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved coverage for host, host group, volume, volume group and snapshot rule #109

Merged
merged 5 commits into from
Jul 10, 2023
Merged

improved coverage for host, host group, volume, volume group and snapshot rule #109

merged 5 commits into from
Jul 10, 2023

Conversation

Sakshi-dell
Copy link
Contributor

@Sakshi-dell Sakshi-dell commented Jul 3, 2023 •
edited by prajwalpatil25
Loading

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

Improved UT coverage for host.go, host_group.go and snapshot_rule.go
current coverage:
image
image
image
image
image
image

@suryagupta4
Copy link
Contributor

Please update the copyright year in all the modified files wherever applicable.

@prajwalpatil25 prajwalpatil25 changed the title improved coverage for host, host group and snapshot rule improved coverage for host, host group, volume, volume group and snapshot rule Jul 6, 2023
AkshaySainiDell
AkshaySainiDell approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sakshi-dell Sakshi-dell merged commit e0f94c9 into main Jul 10, 2023
@shanmydell shanmydell deleted the Adding-UT branch January 31, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@gilltaran gilltaran Awaiting requested review from gilltaran

@kenivi1 kenivi1 Awaiting requested review from kenivi1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sakshi-dell @suryagupta4 @AkshaySainiDell @adarsh-dell @prajwalpatil25