Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go modules #51

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update go modules #51

merged 1 commit into from
Jul 18, 2023

Conversation

chimanjain
Copy link
Collaborator

@chimanjain chimanjain commented Jul 18, 2023 •
edited
Loading

Update following Go Modules:

  • github.com/sirupsen/logrus
  • github.com/stretchr/testify

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Screenshot 2023-07-18 111236

Screenshot 2023-07-18 111304

shefali-malhotra
shefali-malhotra approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefali-malhotra shefali-malhotra merged commit 57ab388 into main Jul 18, 2023
@shefali-malhotra shefali-malhotra deleted the update-modules branch July 18, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chimanjain @shefali-malhotra @HarishH-DELL