Addressed PR comments

dell · Feb 24, 2022 · 7bcc578 · 7bcc578
1 parent de3994c
commit 7bcc578
Show file tree

Hide file tree

Showing 33 changed files with 344 additions and 31 deletions.
diff --git a/acls.go b/acls.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/acls_test.go b/acls_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/api_ordered_values.go b/api/api_ordered_values.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/api_ordered_values_test.go b/api/api_ordered_values_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/api_test.go b/api/api_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/common/utils/poll.go b/api/common/utils/poll.go
@@ -1,3 +1,18 @@
+/*
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
 package utils
 
 // Polling functionality inspired by https://github.com/kubernetes/apimachinery

diff --git a/api/common/utils/utils.go b/api/common/utils/utils.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/common/utils/utils_test.go b/api/common/utils/utils_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v1/api_v1.go b/api/v1/api_v1.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v1/api_v1_exports.go b/api/v1/api_v1_exports.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v1/api_v1_quotas.go b/api/v1/api_v1_quotas.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v1/api_v1_snapshots.go b/api/v1/api_v1_snapshots.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v1/api_v1_zones.go b/api/v1/api_v1_zones.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v11/api_v11_replication.go b/api/v11/api_v11_replication.go
@@ -1,3 +1,18 @@
+/*
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
 package v11
 
 import (
@@ -191,9 +206,12 @@ func StartSyncIQJob(ctx context.Context, client api.Client, job *JobRequest) (*J
 func GetReport(ctx context.Context, client api.Client, reportName string) (*Report, error) {
 	r := &Reports{}
 	err := client.Get(ctx, reportsPath, reportName, nil, nil, &r)
-	if err != nil || len(r.Reports) == 0 {
+	if err != nil {
 		return nil, err
 	}
+	if len(r.Reports) == 0 {
+		return nil, fmt.Errorf("no reports found with report name %s", reportName)
+	}
 	return &r.Reports[0], nil
 }
 

diff --git a/api/v2/api_v2.go b/api/v2/api_v2.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_acls.go b/api/v2/api_v2_acls.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_exports.go b/api/v2/api_v2_exports.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_exports_json_test.go b/api/v2/api_v2_exports_json_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_exports_test.go b/api/v2/api_v2_exports_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_fs.go b/api/v2/api_v2_fs.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v2/api_v2_types.go b/api/v2/api_v2_types.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v3/api_v3.go b/api/v3/api_v3.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v3/api_v3_cluster.go b/api/v3/api_v3_cluster.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/api/v3/api_v3_types.go b/api/v3/api_v3_types.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/client_test.go b/client_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/cluster.go b/cluster.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/cluster_test.go b/cluster_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/exports_test.go b/exports_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/quota.go b/quota.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.

diff --git a/quota_test.go b/quota_test.go
@@ -1,5 +1,5 @@
 /*
- Copyright (c) 2019 Dell Inc, or its subsidiaries.
+ Copyright (c) 2022 Dell Inc, or its subsidiaries.
 
  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.