Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NVMe Connect Changes #3

Merged
merged 1 commit into from
Feb 9, 2022
Merged

NVMe Connect Changes #3

merged 1 commit into from
Feb 9, 2022

Conversation

harshitap26
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

harishp8889
harishp8889 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the template and make sure the tests are done and mention the same in the PR template

@francis-nijay francis-nijay merged commit 6e98df0 into main Feb 9, 2022
@anandrajak1 anandrajak1 deleted the feature/nvme-connect-changes branch October 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francis-nijay francis-nijay francis-nijay approved these changes

@harishp8889 harishp8889 harishp8889 approved these changes

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@spriya-m spriya-m Awaiting requested review from spriya-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshitap26 @harishp8889 @francis-nijay