Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipath Bugfix Changes #10

Merged
merged 6 commits into from
Feb 24, 2022
Merged

Multipath Bugfix Changes #10

merged 6 commits into from
Feb 24, 2022

Conversation

harshitap26
Copy link
Collaborator

@harshitap26 harshitap26 commented Feb 24, 2022

Description

The PR includes changes on the gonvme functions (ListNamespaceDevices and GetNamespaceData) to include the namespace in the output, which is required for the bugfix on Gobrick side.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#158

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on Linux environment with nvme library installed
  • Changes on ListNamespaceDevices and GetNamespaceData are successful

Changes Done - Included the namespace in the output of both the function - ListNamespaceDevices and GetNamespaceData

ListNamespaceDevices Output - 
{devicePath namespace} [namespaceId1 namespaceId2]
{/dev/nvme0n1 54} [0x36 0x37]
{/dev/nvme0n2 55} [0x36 0x37]
{/dev/nvme1n1 54} [0x36 0x37]
{/dev/nvme1n2 55} [0x36 0x37]

Changes Made will be reflected for the bug caused in creating an NVMe pod with multiple volumes on the Gobrick side.

@harishp8889 harishp8889 merged commit dcb82ce into main Feb 24, 2022
@harshitap26 harshitap26 deleted the multipath-fix-changes branch July 19, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants