Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failures fix #57

Merged
merged 15 commits into from
Sep 19, 2024
Merged

Unit test failures fix #57

merged 15 commits into from
Sep 19, 2024

Conversation

francis-nijay
Copy link
Contributor

Description

Fix unit tests that were failing for some time in fc, iscsi and nvme

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1469

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test run successfully without failures

@donatwork donatwork self-requested a review September 19, 2024 04:06
@adarsh-dell
Copy link
Contributor

Can see some panic in the log. I believe we should handle it properly.
image

@adarsh-dell
Copy link
Contributor

Can see some panic in the log. I believe we should handle it properly. image

As per the github action this will run the UT of all packages but make test will only cover 2 packages.
image
image

@francis-nijay
Copy link
Contributor Author

Fixing the test failures in other packages is in progress. Will run all tests from github actions preferably

As there are some methods that are calling the cli with diff diff args so mock should handle it for any args type.
@adarsh-dell
Copy link
Contributor

Ran UT locally for all packages:

image

Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job getting these fixed. Thanks.

@donatwork donatwork merged commit 46d67e0 into main Sep 19, 2024
5 checks passed
@donatwork donatwork deleted the fix/unit-tests branch September 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants