Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection and matching of wwn to nguid. #56

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Sep 17, 2024

Description

Fix regression introduced when matching device wwn with nguid. The fix will make the proper checks based on platform. Added unit tests for this method.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1469

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

I was able to reproduce the problem in the lab. Saw the same errors as reported. With the fix the failure is gone and the new log traces look like the following;

START: NVMeConnector.discoverDevice
{"level":"debug","msg":"DevicePathsAndNamespaces [{DevicePath:/dev/nvme0n1 Namespace:40074}] retryCount 0","time":"2024-09-19T03:50:49.015887629Z"}
{"level":"debug","msg":"nguid eafbf604e377aa068ccf096800495ec4, wwn 68ccf09800eafbf604e377aa06495ec4, newnamespace 40074, namespace 40074","time":"2024-09-19T03:50:49.038451238Z"}
{"level":"info","msg":"PowerStore: bf604e377aa0 495ec eafbf604e377aa068ccf096800495ec4 true","time":"2024-09-19T03:50:49.038506058Z"}
END: NVMeConnector.discoverDevice
{

@donatwork donatwork merged commit 0821759 into main Sep 19, 2024
5 checks passed
@donatwork donatwork deleted the 1469_nvme_wwn_matching branch September 19, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants