Fix detection and matching of wwn to nguid. #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix regression introduced when matching device wwn with nguid. The fix will make the proper checks based on platform. Added unit tests for this method.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
I was able to reproduce the problem in the lab. Saw the same errors as reported. With the fix the failure is gone and the new log traces look like the following;
START: NVMeConnector.discoverDevice
{"level":"debug","msg":"DevicePathsAndNamespaces [{DevicePath:/dev/nvme0n1 Namespace:40074}] retryCount 0","time":"2024-09-19T03:50:49.015887629Z"}
{"level":"debug","msg":"nguid eafbf604e377aa068ccf096800495ec4, wwn 68ccf09800eafbf604e377aa06495ec4, newnamespace 40074, namespace 40074","time":"2024-09-19T03:50:49.038451238Z"}
{"level":"info","msg":"PowerStore: bf604e377aa0 495ec eafbf604e377aa068ccf096800495ec4 true","time":"2024-09-19T03:50:49.038506058Z"}
END: NVMeConnector.discoverDevice
{