Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates scsi rescan to use the LUN number in rescan command #54

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

delldubey
Copy link
Contributor

Description

This PR:

  • This updates the rescan logic in findHCTLsForFCHBA function to use LUN number instead of '-', which scans for all the luns on a host.
  • The LUN number is primarily part of NodeStageRequest.
  • This saves us the issue of having a ghost/invalid sd* disk post NodeUnstage and there is a rescan for new devices at the same time.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1379

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test
  • Cluster test

Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely do some regression testing with PowerStore.

@delldubey delldubey merged commit cacb47e into main Jul 18, 2024
4 checks passed
@suryagupta4 suryagupta4 mentioned this pull request Aug 8, 2024
10 tasks
@anandrajak1 anandrajak1 deleted the lun_rescan branch October 17, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants