Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the linting error #45

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Fixing the linting error #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b078b7
fixing linting error
tssushma Sep 29, 2023
6bf026f
Update linters.yaml
tssushma Dec 15, 2023
2c562c2
Update linters.yaml
tssushma Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/setup-go@v4
with:
go-version: "1.21"
go-version: "1.20"
cache: false
- name: Checkout the code
uses: actions/[email protected]
Expand Down
8 changes: 4 additions & 4 deletions base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func (bc *baseConnector) disconnectDevicesByDeviceName(ctx context.Context, name
var wwn string
if strings.HasPrefix(name, deviceMapperPrefix) {
wwn, err = bc.getDMWWN(ctx, name)

} else {
wwn, err = bc.scsi.GetDeviceWWN(ctx, []string{name})
}
Expand All @@ -114,7 +113,6 @@ func (bc *baseConnector) disconnectNVMEDevicesByDeviceName(ctx context.Context,
var wwn string
if strings.HasPrefix(name, deviceMapperPrefix) {
wwn, err = bc.getNVMEDMWWN(ctx, name)

} else {
wwn, err = bc.scsi.GetNVMEDeviceWWN(ctx, []string{name})
}
Expand All @@ -132,7 +130,8 @@ func (bc *baseConnector) disconnectNVMEDevicesByDeviceName(ctx context.Context,
}

func (bc *baseConnector) cleanNVMeDevices(ctx context.Context,
force bool, devices []string) error {
force bool, devices []string,
) error {
defer tracer.TraceFuncCall(ctx, "baseConnector.cleanNVMeDevices")()
var newDevices []string
for _, device := range devices {
Expand Down Expand Up @@ -168,7 +167,8 @@ func (bc *baseConnector) cleanNVMeDevices(ctx context.Context,
}

func (bc *baseConnector) cleanDevices(ctx context.Context,
force bool, devices []string) error {
force bool, devices []string,
) error {
defer tracer.TraceFuncCall(ctx, "baseConnector.cleanDevices")()
dm, err := bc.scsi.GetDMDeviceByChildren(ctx, devices)
if err != nil {
Expand Down
Loading