-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idrac_certificates]: Add CustomCertificate certificate_type (#485) #562
Merged
sachin-apa
merged 35 commits into
dell:collections
from
KristianLamb:feature/idrac_certificates
Dec 21, 2023
Merged
[idrac_certificates]: Add CustomCertificate certificate_type (#485) #562
sachin-apa
merged 35 commits into
dell:collections
from
KristianLamb:feature/idrac_certificates
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## collections #562 +/- ##
===============================================
+ Coverage 93.00% 93.05% +0.04%
===============================================
Files 191 191
Lines 30507 30574 +67
Branches 4798 4809 +11
===============================================
+ Hits 28374 28450 +76
+ Misses 1309 1304 -5
+ Partials 824 820 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sachin-apa
reviewed
Dec 5, 2023
afea125
to
da0d283
Compare
ShivamSh3
previously approved these changes
Dec 20, 2023
Kritika-Bhateja-03
previously approved these changes
Dec 20, 2023
a4cc416
sachin-apa
approved these changes
Dec 21, 2023
Kritika-Bhateja-03
approved these changes
Dec 21, 2023
ShivamSh3
approved these changes
Dec 21, 2023
jagadeeshnv
approved these changes
Dec 21, 2023
jagadeeshnv
approved these changes
Dec 21, 2023
rajshekarp87
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
CustomCertificate
certificate_type for Import/Export of DelliDRACCardService.GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
COMPONENT NAME
idrac_certificates
OUTPUT
ADDITIONAL INFORMATION
Checklist: