Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-Powerstore: Add OpenShift support for driver v2.5 #96

Merged
merged 1 commit into from
Oct 31, 2022
Merged

CSI-Powerstore: Add OpenShift support for driver v2.5 #96

merged 1 commit into from
Oct 31, 2022

Conversation

satyakonduri
Copy link
Contributor

Description

  • Add OpenShift support for 2.5 driver

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#480

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Created Application pods and run CERT-CSI.

@satyakonduri satyakonduri self-assigned this Oct 27, 2022
spriya-m
spriya-m previously approved these changes Oct 27, 2022
View reviewed changes
@spriya-m spriya-m changed the title CSI-Powerstore: Add OPS support for 2.5 dirver CSI-Powerstore: Add OpenShift support for driver v2.5 Oct 27, 2022
suryagupta4
suryagupta4 previously approved these changes Oct 28, 2022
View reviewed changes
rensyct
rensyct suggested changes Oct 31, 2022
View reviewed changes
samples/powerstore_v250_ops_411.yaml Outdated
# Default value: None
nodeSelector:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
# node-role.kubernetes.io/master: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this as we dont have master from K8s 1.24 and OCP 4.11 uses K8s 1.24

Copy link
Contributor Author

@satyakonduri satyakonduri Oct 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You @rensyct
Addressed

samples/powerstore_v250_ops_411.yaml Outdated
# Default value: None
tolerations:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
# - key: "node-role.kubernetes.io/master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

samples/powerstore_v250_ops_411.yaml Outdated
# Default value: None
nodeSelector:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
# node-role.kubernetes.io/master: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

samples/powerstore_v250_ops_411.yaml Outdated
# Default value: None
tolerations:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
# - key: "node-role.kubernetes.io/master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@satyakonduri satyakonduri dismissed stale reviews from suryagupta4 and spriya-m via d93959f October 31, 2022 07:33
@satyakonduri satyakonduri force-pushed the ops_support_2.5_driver branch from b4efcd9 to d93959f Compare October 31, 2022 07:33
@rensyct rensyct merged commit f33edc6 into main Oct 31, 2022
@spriya-m spriya-m linked an issue Nov 25, 2022 that may be closed by this pull request
[FEATURE]: CSM support for Openshift 4.11 dell/csm#480
Closed
@rensyct rensyct deleted the ops_support_2.5_driver branch January 3, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rensyct rensyct rensyct approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@spriya-m spriya-m Awaiting requested review from spriya-m

Assignees

@satyakonduri satyakonduri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: CSM support for Openshift 4.11
5 participants
@satyakonduri @rensyct @spriya-m @suryagupta4 @adarsh-dell