Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeselector and toleration changes #63

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

gilltaran
Copy link
Contributor

Description

Update default node-selector value from master to control-plane for K8s 1.24.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#256

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the driver and tested.

@rensyct
Copy link
Contributor

rensyct commented Jun 6, 2022

Also please ensure to add the right version of external health monitor sidecar for previous releases of Powerstore in config.yaml file

samples/powerstore_v230_k8s_124.yaml Outdated Show resolved Hide resolved
@gilltaran gilltaran requested a review from bandak2 as a code owner June 7, 2022 06:29
@gilltaran gilltaran requested a review from rensyct June 7, 2022 12:00
@Prabhu-Dell Prabhu-Dell merged commit 44104ef into main Jun 9, 2022
@rensyct rensyct deleted the powerstore-nodeSelectors-toleration-changes branch July 18, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants