Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-PowerScale: Leader lection timeout flag values in sync with helm #29

Merged
merged 3 commits into from
Mar 4, 2022
Merged

CSI-PowerScale: Leader lection timeout flag values in sync with helm #29

merged 3 commits into from
Mar 4, 2022

Conversation

Sakshi-dell
Copy link
Contributor

Description

Leader election timeout flags were added for operator but the value was different from helm so updated the same to be in sync.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#209

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Only sample file values updated they are being reflected in the driver
  • unit tests are passing

randeepdell
randeepdell previously approved these changes Mar 3, 2022
View reviewed changes
@Sakshi-dell Sakshi-dell force-pushed the leader-election-flag-value-update branch from 0a5accd to e3bf1b0 Compare March 4, 2022 09:37
@rensyct rensyct merged commit e1a93a3 into main Mar 4, 2022
@rensyct rensyct deleted the leader-election-flag-value-update branch March 4, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@rensyct rensyct rensyct approved these changes

@randeepdell randeepdell randeepdell left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@coulof coulof Awaiting requested review from coulof

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7

@prasar6 prasar6 Awaiting requested review from prasar6

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sakshi-dell @rensyct @nitesh3108 @randeepdell