Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POSIX and NFSv4 ACL support #21

Merged
merged 3 commits into from
Feb 24, 2022
Merged

POSIX and NFSv4 ACL support #21

merged 3 commits into from
Feb 24, 2022

Conversation

spriya-m
Copy link
Contributor

Description

Operator updates for POSIX and NFSv4 ACLs

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#191

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified the operator installation is successful with the yaml file updates
  • Verified that the POSIX and NFSv4 ACLs are set as specified on the NFS mount directories

coulof
coulof previously approved these changes Feb 24, 2022
View reviewed changes
francis-nijay
francis-nijay previously approved these changes Feb 24, 2022
View reviewed changes
rensyct
rensyct suggested changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit tests

@spriya-m spriya-m dismissed stale reviews from francis-nijay and coulof via 5568a3a February 24, 2022 10:39
francis-nijay
francis-nijay previously approved these changes Feb 24, 2022
View reviewed changes
@francis-nijay francis-nijay self-requested a review February 24, 2022 13:23
@spriya-m
Copy link
Contributor Author

spriya-m commented Feb 24, 2022 •
edited
Loading

Please fix the unit tests

done, fixed unit tests.

@rensyct rensyct merged commit 8a0a114 into main Feb 24, 2022
@spriya-m spriya-m deleted the feature/nfsv4-acls branch March 2, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@francis-nijay francis-nijay francis-nijay approved these changes

@coulof coulof coulof left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@gallacher gallacher Awaiting requested review from gallacher

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7

@prasar6 prasar6 Awaiting requested review from prasar6

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spriya-m @coulof @francis-nijay @rensyct