Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync private repo latest changes #18

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Sync private repo latest changes #18

merged 1 commit into from
Feb 18, 2022

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Feb 17, 2022 •
edited by gallacher
Loading

Description

  • Synced latest changes in the private repo of dell-csi-operator
  • Updated git hub actions with unit test checks

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#161

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Tested by installing operator and deploying unity driver on top of it in dev mode in a single node cluster. Please find the screenshot below showing pods running successfully for unity driver
    image

panigs7
panigs7 previously approved these changes Feb 18, 2022
View reviewed changes
@rajendraindukuri rajendraindukuri force-pushed the sync-private-repo-latest-changes branch 5 times, most recently from 1d8dca5 to 3b7c3d2 Compare February 18, 2022 10:50
@rajendraindukuri
sync public repo
98e4928 
Updating go.sum

Updated actions.yaml
@rajendraindukuri rajendraindukuri force-pushed the sync-private-repo-latest-changes branch from 3b7c3d2 to 98e4928 Compare February 18, 2022 10:55
@rajendraindukuri
Copy link
Collaborator Author

We will handle unit test failures.. format lint and vet issues as part of another PR. Merging this keeping note of the points mentioned.

@rajendraindukuri rajendraindukuri merged commit ef7647f into main Feb 18, 2022
@rensyct rensyct deleted the sync-private-repo-latest-changes branch March 21, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@rensyct rensyct rensyct approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajendraindukuri @rensyct @panigs7