Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync operator public repo with private repo #16

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Sync operator public repo with private repo #16

merged 4 commits into from
Jan 28, 2022

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Jan 19, 2022 •
edited by gallacher
Loading

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#161

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Tested installing operator using the image and also in dev mode and creating CR for one of the driver modules. it works as expected
  • Enabled checks for gosec, lint. vet and format issues fix for which will be handled as part of another PR

panigs7
panigs7 previously approved these changes Jan 28, 2022
View reviewed changes
@rajendraindukuri rajendraindukuri merged commit a3ab388 into main Jan 28, 2022
@rensyct rensyct deleted the sync-operator-public-repo-with-private-repo branch March 21, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rensyct rensyct Awaiting requested review from rensyct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajendraindukuri @panigs7 @karthikk92 @rajendravarma077