Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pflex rename sdc support #128

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Pflex rename sdc support #128

merged 2 commits into from
Feb 20, 2023

Conversation

khareRajshree
Copy link
Contributor

Description

This PR includes changes for:

  • PowerFlex v2.6 - renameSDC support added.
  • removed vxflex_v260_k8s_123.yaml sample.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#402
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Fresh install of dell-csi-operator with the code changes tested on K8S 1.26 and OCP 4.11.
  • Installed the Powerflex driver and ran cert-csi. The cert-csi suites passed successfully with 100% tests passed.

k get pods -n test-vxflexos
NAME READY STATUS RESTARTS AGE
vxflexos-controller-7c694b4798-mt4nn 5/5 Running 0 3m2s
vxflexos-node-2s4jz 2/2 Running 0 23s
vxflexos-node-glzfr 2/2 Running 0 44s

k logs vxflexos-node-2s4jz -n test-vxflexos
Defaulted container "driver" out of: driver, registrar, sdc (init)
time="2023-02-20T06:22:30Z" level=info msg="configured 0e7a082862fedf0f" allSystemNames= endpoint="https://10.247.101.69" isDefault=false password="********" skipCertificateValidation=true systemID=0e7a082862fedf0f user=admin
time="2023-02-20T06:22:30Z" level=info msg="driver configuration file " file=/vxflexos-config-params/driver-config-params.yaml
time="2023-02-20T06:22:30Z" level=info msg="Read CSI_LOG_FORMAT from log configuration file" format=text
time="2023-02-20T06:22:30Z" level=info msg="Read CSI_LOG_LEVEL from log configuration file" fields.level=debug
time="2023-02-20T06:22:30Z" level=info msg="array configuration file" file=/vxflexos-config/config
time="2023-02-20T06:22:30Z" level=info msg="set SDC GUID" guid=6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8
time="2023-02-20T06:22:30Z" level=info msg="Found connected system" ID=0e7a082862fedf0f
time="2023-02-20T06:22:30Z" level=info msg="NodeInfo ID" node info=6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8
time="2023-02-20T06:22:30Z" level=info msg="NodeInfo topologykeys" node info key=csi-vxflexos.dellemc.com/0e7a082862fedf0f
time="2023-02-20T06:22:30Z" level=info msg="Probing all arrays. Number of arrays: 1"
time="2023-02-20T06:22:30Z" level=info msg="vol id in UpdateVolumePrefixToSystemsMap is: 457e31ed00000090 from systemID: 0e7a082862fedf0f \n"
time="2023-02-20T06:22:30Z" level=info msg="volumePrefixToSystems: adding new key, value pair: key 457, systemID: 0e7a082862fedf0f \n"
time="2023-02-20T06:22:30Z" level=info msg="array 0e7a082862fedf0f probed successfully"
time="2023-02-20T06:22:30Z" level=info msg="set SDC GUID" guid=6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8
time="2023-02-20T06:22:30Z" level=info msg="Assigning name: y-worker-1-OKqkCFuAkNgyX.domain to SDC with GUID 6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8 on system 0e7a082862fedf0f"
time="2023-02-20T06:22:30Z" level=info msg="SDC name set to: y-worker-1-OKqkCFuAkNgyX.domain."

time="2023-02-20T06:22:30Z" level=info msg="configured csi-vxflexos.dellemc.com" IsApproveSDCEnabled=false IsHealthMonitorEnabled=false IsSdcRenameEnabled=true allowRWOMultiPodAccess=false autoprobe=true mode=node privatedir=/var/lib/kubelet/plugins/vxflexos.emc.dell.com/disks sdcGUID=6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8 sdcPrefix=y thickprovision=false
time="2023-02-20T06:22:30Z" level=info msg="identity service registered"
time="2023-02-20T06:22:30Z" level=info msg="node service registered"
time="2023-02-20T06:22:30Z" level=info msg="Registering additional GRPC servers"
time="2023-02-20T06:22:30Z" level=info msg=serving endpoint="unix:///var/lib/kubelet/plugins/vxflexos.emc.dell.com/csi_sock"
time="2023-02-20T06:22:30Z" level=info msg="/csi.v1.Identity/GetPluginInfo: REQ 0001: XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"
time="2023-02-20T06:22:30Z" level=info msg="/csi.v1.Identity/GetPluginInfo: REP 0001: Name=csi-vxflexos.dellemc.com, VendorVersion=2.5.0+24, Manifest=map[commit:3ad4e3830cb1ced460df516bbdabe30e44fb30dc formed:Thu, 16 Feb 2023 16:52:41 UTC semver:2.5.0+24 url:http://github.com/dell/csi-vxflexos], XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"
time="2023-02-20T06:22:30Z" level=info msg="/csi.v1.Node/NodeGetInfo: REQ 0002: XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"
time="2023-02-20T06:22:30Z" level=info msg="/csi.v1.Node/NodeGetInfo: REP 0002: NodeId=6224BF53-1A1F-57E1-8CB8-C2D0BA9281C8, MaxVolumesPerNode=0, AccessibleTopology=segments:<key:"csi-vxflexos.dellemc.com/0e7a082862fedf0f" value:"csi-vxflexos.dellemc.com" > , XXX_NoUnkeyedLiteral={}, XXX_sizecache=0"

cert-csi results:

[2023-02-20 01:29:52] INFO Avg time of a run: 61.42s
[2023-02-20 01:29:52] INFO Avg time of a del: 14.29s
[2023-02-20 01:29:52] INFO Avg time of all: 78.71s
[2023-02-20 01:29:52] INFO During this run 100.0% of suites succeeded

@khareRajshree khareRajshree merged commit cf6e897 into main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants