Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license headers #110

Merged
merged 7 commits into from
Nov 24, 2022
Merged

Add license headers #110

merged 7 commits into from
Nov 24, 2022

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Nov 21, 2022 •
edited
Loading

Description

Adding license headers

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Sanity test passed.

@panigs7 panigs7 force-pushed the feature-491-license-headers branch from 2760fc8 to c9a8484 Compare November 23, 2022 07:29
@panigs7 panigs7 force-pushed the feature-491-license-headers branch from fe93c30 to b050f13 Compare November 24, 2022 10:32
rensyct
rensyct reviewed Nov 24, 2022
View reviewed changes
check.sh Outdated
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be moved above the copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rensyct rensyct merged commit af33e75 into main Nov 24, 2022
@rensyct rensyct deleted the feature-491-license-headers branch January 3, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikk92 karthikk92 karthikk92 approved these changes

@rensyct rensyct rensyct approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panigs7 @rensyct @rajendraindukuri @karthikk92