Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the go and grpc version for podmon #67

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

chaganti-rajitha
Copy link
Contributor

Description

Updated the go version for podmon

GitHub Issues

List the GitHub issues impacted by this PR:
| GitHub Issue # |
| dell/csm#1435 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

I have used these code changes and built image for karavi-resiliency repo and performed short-integration test.
Screenshot 2024-10-15 132834

Unit-Test code coverage:

image
Built image and pushed to harbor and ran short-integration-test
image

@chaganti-rajitha chaganti-rajitha requested review from chimanjain, nitesh3108 and satyakonduri and removed request for chimanjain October 16, 2024 06:39
@chimanjain
Copy link
Contributor

Can you please update the grpc and go version in other sub modules in this repository to maintain consistency.

@chaganti-rajitha
Copy link
Contributor Author

chaganti-rajitha commented Oct 16, 2024

Can you please update the grpc and go version in other sub modules in this repository to maintain consistency.

For resiliency Podmon, after editing versions we have tested them and raised PR but for other modules, it would be better the respective teams test the changes and update

@chaganti-rajitha chaganti-rajitha merged commit ba90cfd into main Oct 16, 2024
9 checks passed
@chaganti-rajitha chaganti-rajitha deleted the podmon_version_updates branch October 16, 2024 09:21
Copy link
Contributor

@santhoshatdell santhoshatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chaganti-rajitha: Historically, we have been updating the go mod references across all sub modules in a single PR. These changes will eventually be pulled in by respective modules and be tested.
Could you see if you can update other sub modules as well? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants