Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log #229

Merged
merged 10 commits into from
Mar 23, 2022
Merged

Add change log #229

merged 10 commits into from
Mar 23, 2022

Conversation

gallacher
Copy link
Contributor

Description

Updated the features/bug fixes list.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@gallacher gallacher changed the base branch from main to release-v1.2.0 March 21, 2022 12:25
randeepdell
randeepdell previously approved these changes Mar 21, 2022
sharmilarama
sharmilarama previously approved these changes Mar 21, 2022
LJ-Software
LJ-Software previously approved these changes Mar 21, 2022
@@ -66,11 +70,11 @@
- CSM Authorization sidecar install fails if k8s worker nodes are not in ~/.ssh/known_hosts. ([#147](https://github.com/dell/csm/issues/147))
- Container is terminated but Pod is stuck in terminating. ([#146](https://github.com/dell/csm/issues/146))
- Dell CSI Operator listed two times after upgrade (1.2.0 + 1.5.0). ([#144](https://github.com/dell/csm/issues/144))
- Failing to create replicated volumes with Integration tests . ([#143](https://github.com/dell/csm/issues/143))
- Failing to create replicated volumes with Integration tests. ([#143](https://github.com/dell/csm/issues/143))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there still is an extras pace in here. "volumes with Integration tests"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the extra space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now :)

hoppea2
hoppea2 previously approved these changes Mar 22, 2022
@gallacher gallacher dismissed stale reviews from shaynafinocchiaro and hoppea2 via 785f067 March 23, 2022 12:17
@gallacher gallacher merged commit 623d3cf into release-v1.2.0 Mar 23, 2022
@gallacher gallacher deleted the add-change-log branch March 23, 2022 12:21
gallacher added a commit that referenced this pull request Mar 23, 2022
* add v1.2.0 changelog (#221)

* Add change log (#226)

* add v1.2.0 changelog

* Updated section to 'Bug Fixes'

* Updated section headings

* Update CHANGELOG-1.2.0.md

* Added missing features and bugs to changelog

* Add change log (#229)

* add v1.2.0 changelog

* Updated section to 'Bug Fixes'

* Updated section headings

* Update CHANGELOG-1.2.0.md

* Added missing features and bugs to changelog

* Updated feature/bug list

* Added known issues

* Removed extra space
hoppea2 pushed a commit that referenced this pull request May 24, 2022
* add v1.2.0 changelog (#221)

* Add change log (#226)

* add v1.2.0 changelog

* Updated section to 'Bug Fixes'

* Updated section headings

* Update CHANGELOG-1.2.0.md

* Added missing features and bugs to changelog

* Add change log (#229)

* add v1.2.0 changelog

* Updated section to 'Bug Fixes'

* Updated section headings

* Update CHANGELOG-1.2.0.md

* Added missing features and bugs to changelog

* Updated feature/bug list

* Added known issues

* Removed extra space

* Added changelog entry for release v1.2.1

* Added new bug description to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants