Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to release CSM #1646

Closed
wants to merge 1 commit into from
Closed

Conversation

riya-kaushal7997
Copy link
Contributor

@riya-kaushal7997 riya-kaushal7997 commented Dec 18, 2024

Description

Added github actions to release CSM

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@csmbot
Copy link
Collaborator

csmbot commented Dec 18, 2024

@riya-kaushal7997: Thank you for submitting your pull request!

Please make sure you have followed our contributing guidelines. We will review it as soon as possible.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at [email protected].

@riya-kaushal7997 riya-kaushal7997 marked this pull request as draft December 18, 2024 06:18
@riya-kaushal7997 riya-kaushal7997 marked this pull request as ready for review December 18, 2024 06:30
@riya-kaushal7997 riya-kaushal7997 marked this pull request as draft December 18, 2024 11:34
## Documentation
- [General Documentation](https://dell.github.io/csm-docs/docs/)
## Change Log
See the [CHANGELOG](https://github.com/dell/csm/blob/main/CHANGELOG/CHANGELOG-${{ env.version }}.md) for more details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a dead link if it were a patch release because the patch changes are always added to an existing changelog. See as an example: https://github.com/dell/csm/blob/main/CHANGELOG/CHANGELOG-1.11.0.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaynafinocchiaro, I updated the code with the patch release fix.
Created a new PR with updates: #1649, Please review the same.

Closing this PR as this one is a protected branch.

@riya-kaushal7997
Copy link
Contributor Author

Closing this PR as this branch is a protected branch. Create new PR: #1649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants