Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csm-replication/Add Makefile Targets for Local PR Checks #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgandharva
Copy link

@mgandharva mgandharva commented Jan 30, 2025

Description

This PR adds Makefile targets to run GitHub Actions checks locally:

actions Target :
Runs all pull request checks with enhanced logging.
action-help Target :
Displays instructions for running specific workflows with act.
Usage:

Run all PR checks: make actions
Get workflow instructions: make action-help
Enhances local testing and debugging of GitHub Actions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested locally using command: make actions
    image

Copy link
Contributor

@khareRajshree khareRajshree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide the detail on how this action was tested, like any screenshots of the local testing done. Thanks.

@mgandharva
Copy link
Author

Can you please provide the detail on how this action was tested, like any screenshots of the local testing done. Thanks.

@khareRajshree I have updated the description with the test, please re-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants