-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove auth secret #831
base: main
Are you sure you want to change the base?
Remove auth secret #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sahiba-Gupta please link GitHub feature and review the checkboxes about maintaining unit test coverage etc.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to run operator e2e tests for pmax before we can merge this. Ping me @Sahiba-Gupta and I can help with that.
Also, we need to make corresponding changes to the csi-powermax sample files in tests/e2e/testfiles (delete AuthSecret field in those files as well) |
closed by mistake sorry |
This PR will remove any code in the driver that requires the auth secret should be updated/removed.
Github Issue:
dell/csm#1614
Checklist:
I have tested it locally by deploying driver: