Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth secret #831

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove auth secret #831

wants to merge 6 commits into from

Conversation

Sahiba-Gupta
Copy link

@Sahiba-Gupta Sahiba-Gupta commented Dec 18, 2024

This PR will remove any code in the driver that requires the auth secret should be updated/removed.

Github Issue:

dell/csm#1614

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

I have tested it locally by deploying driver:

[root@master-1-CSfRuoF2t9HI2 csm-operator]# k get pods -n powermax
NAME                                   READY   STATUS    RESTARTS     AGE
powermax-controller-6dcf8b8d8f-n5xff   6/6     Running   4 (2s ago)   7s
powermax-node-c6msh                    2/2     Running   0            7s
powermax-node-gzgvp                    2/2     Running   0            7s
powermax-node-tpzzv                    2/2     Running   0            7s

@Sahiba-Gupta Sahiba-Gupta changed the title /KRV-30626 : Remove auth secret KRV-30626 : Remove auth secret Dec 18, 2024
Copy link
Contributor

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sahiba-Gupta please link GitHub feature and review the checkboxes about maintaining unit test coverage etc.

@hoppea2 hoppea2 changed the title KRV-30626 : Remove auth secret Remove auth secret Dec 18, 2024
@Sahiba-Gupta
Copy link
Author

@Sahiba-Gupta please link GitHub feature and review the checkboxes about maintaining unit test coverage etc.

Done

@Sahiba-Gupta Sahiba-Gupta requested a review from hoppea2 December 19, 2024 07:22
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to run operator e2e tests for pmax before we can merge this. Ping me @Sahiba-Gupta and I can help with that.

@jooseppi-luna
Copy link
Contributor

Also, we need to make corresponding changes to the csi-powermax sample files in tests/e2e/testfiles (delete AuthSecret field in those files as well)

@jooseppi-luna
Copy link
Contributor

closed by mistake sorry

@jooseppi-luna jooseppi-luna reopened this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants