Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver as init container to daemonset #828

Merged
merged 17 commits into from
Dec 19, 2024
Merged

Conversation

JacobGros
Copy link
Contributor

@JacobGros JacobGros commented Dec 16, 2024

Description

This PR adds some daemonset changes to the v2.13 powerflex driver. Instead of reading MDM value from secret, the SDC init container will now source this variable from a shared volume. This volume will be written to by the driver when its deployed as an init container before the SDC. These changes include deploying the driver as an init container and configuring the SDC to source from shared volume.
There are also some updates to images used in e2e tests and updating some powerflex e2e tests to make use of the new method for secret creation added here: #818

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1613

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • ran nohup ./run-e2e-test.sh --pflex & , results tracked internally
  • Installed on OCP using secret w/ zones and secret w/o zones. results tracked internally

@JacobGros JacobGros requested a review from alexemc December 18, 2024 21:46
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@JacobGros JacobGros merged commit a892d43 into main Dec 19, 2024
7 checks passed
@JacobGros JacobGros deleted the pub/add-driver-as-init branch December 19, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants