Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve zone information from multi array secret #819

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

EvgenyUglov
Copy link
Contributor

@EvgenyUglov EvgenyUglov commented Dec 9, 2024

Description

PR fixes retrieving zone information from multi array secret

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1613

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • unit tests
        github.com/dell/csm-operator            coverage: 0.0% of statements
        github.com/dell/csm-operator/api/v1             coverage: 0.0% of statements
        github.com/dell/csm-operator/core               coverage: 0.0% of statements
?       github.com/dell/csm-operator/pkg/constants      [no test files]
        github.com/dell/csm-operator/core/semver                coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/logger         coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/clientgoclient                coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared               coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/crclient              coverage: 0.0% of statements
ok      github.com/dell/csm-operator/controllers        55.161s coverage: 89.2% of statements
ok      github.com/dell/csm-operator/k8s        0.052s  coverage: 90.3% of statements
ok      github.com/dell/csm-operator/pkg/drivers        0.237s  coverage: 96.1% of statements
ok      github.com/dell/csm-operator/pkg/modules        2.211s  coverage: 90.1% of statements
ok      github.com/dell/csm-operator/pkg/resources/configmap    0.043s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/csidriver    0.022s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/daemonset    0.086s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/deployment   0.049s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/rbac 0.076s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/resources/serviceaccount       0.065s  coverage: 100.0% of statements
ok      github.com/dell/csm-operator/pkg/utils  3.109s  coverage: 81.9% of statements

@EvgenyUglov EvgenyUglov merged commit 6e3737c into main Dec 10, 2024
7 checks passed
@EvgenyUglov EvgenyUglov deleted the usr/evgeny/fix-multi-array-zone branch December 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants