[WIP] Increase coverage for driver package #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshi-garg1
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
atye and
sharmilarama
as code owners
sakshi-garg1
changed the title
AkshaySainiDell
added a commit
that referenced
this pull request
Dec 20, 2024
* set default replicas to 2 if not specified * set default path for KUBELET_CONFIG_DIR * set default path for KUBELET_CONFIG_DIR * define DefaultKubeletConfigDir * Same KUBECONFIG_DIR changes for powerscale and powerstore. Tested on K8S. * updated structs to pointers * Remove mdm from CR. We still need to add the MDM var to the daemonset. * fixed operator crashing * [WIP] Increase coverage for driver package (#801) * Update common_test.go to increase powerscale.go coverage * Update powerscale_test.go * Fixed initContainers in CR * Update common_test.go for increaing powermax.go coverage * Update common_test.go * Update common_test.go to increase powerflex.go coverage * fixed linting errors * fixed linting errors * fixed yaml linting errors * To increase coverage for powerstore.go * Increase coverage for unity.go file * Increase coverage for unity.go file * To increase coverage for unity.go * To increase coverage for commonconfig.go * To increase coverage for commonconfig.go * Fixed Linting issues * Fixed Linting issues * Fixed Linting issues * fixed linters error * fixed linters error * e2e tests for minimal sample * Removing code that defaults replica count in deployment and CR to 2 when it comes in as 0. * Fix linter error. * addressed @rajendraindukuri & @kumarp20 review comment * fixed liniting errors for crd * added no mdm unit test * fixed reverseproxy envs * Inject ReverseProxy directly into the deployment * Refactor ReverseProxy code * Fix unit test failures * Fix step_defs.go * Increase coverage of controller * Increase coverage of controller * Fix gosec error * Fix lint error * Increase coverage of reverseproxy * Fix lint error * Fix minimal e2e scenarios * Fix driver UT --------- Co-authored-by: Surya Gupta <[email protected]> Co-authored-by: Rishabh Raj <[email protected]> Co-authored-by: sakshi-garg1 <[email protected]> Co-authored-by: Akshay Saini <[email protected]> Co-authored-by: Akshay Saini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase coverage for driver package
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
make driver-unit-test