Complete auth support #8
Conversation
medegw01
force-pushed
the
complete-auth-support
branch
from
151fef5 to
dbe7c9d
Compare
|
Linting errors are failing the action. Also, update the GitHub Issue in the description to dell/csm#159 |
resolved |
| return fmt.Errorf("CSM Authorization does not support %s driver", driverType) | ||
| } | ||
|
|
||
| // check if provided version is supported |
There was a problem hiding this comment.
Do we support the case where I specify a version of the PowerScale driver but don't specify the version of Authorization? In that case, the operator should know which version of Authorization should be used based on our support matrix.
There was a problem hiding this comment.
Yes, that's the default behavior I am testing. Please see the test file: https://github.com/dell/csm-operator/blob/complete-auth-support/pkg/modules/testdata/cr_powerscale_auth.yaml and corresponding prechecks testing it:
And finally, here is the line in the code that calls the default:
csm-operator/pkg/modules/authorization.go
Line 42 in 9c698fa
* Adding Unit teste * resolve golinbt issues
* update reconcile to use workque , predicate add watch on daemonset refactor to use apply for daemonset test apply change on cr for daemonset remove kubernetes module in go.mod * Complete auth support (#8) * Adding Unit teste * resolve golinbt issues * fix merge conflicts * update authorization helper to use apply for daemonset * fix auth test type errors * actions need container built with golang:1.17 * set go.mod controller-runtime to 0.10.3 , 0.11.0 fails to build with actions image-scanner * remove comments on calls where type changed Co-authored-by: Michael Edegware <[email protected]>
* Adding Unit teste * resolve golinbt issues
* update reconcile to use workque , predicate add watch on daemonset refactor to use apply for daemonset test apply change on cr for daemonset remove kubernetes module in go.mod * Complete auth support (#8) * Adding Unit teste * resolve golinbt issues * fix merge conflicts * update authorization helper to use apply for daemonset * fix auth test type errors * actions need container built with golang:1.17 * set go.mod controller-runtime to 0.10.3 , 0.11.0 fails to build with actions image-scanner * remove comments on calls where type changed Co-authored-by: Michael Edegware <[email protected]>
Description
This PR adds unit tests to the authorization module and k8s package
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration