Increase unit test coverage #785

donatwork · 2024-11-18T12:51:53Z

Description

This is a joint effort to increase the unit test coverage to meet the unit test threshold.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1559

Checklist:

I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
I have verified that new and existing unit tests pass locally with my changes
I have not allowed coverage numbers to degenerate
I have maintained at least 80% code coverage
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (N/A)
I have added tests that prove my fix is effective or that my feature works
I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Unit tests are performed and passing at the threshold set by the relevant GitHub action.

…/csm-operator into pub/increase-utils-coverage

…bility

…/csm-operator into pub/increase-utils-coverage

pkg/utils/status_test.go

pkg/utils/utils.go

tests/shared/common.go

pkg/utils/utils_test.go

ChristianAtDell · 2024-11-18T19:57:58Z

I will go and remove all of the known useless comment chunks and resolve those conversations.

Signed-off-by: meghana_gm <[email protected]>

alexemc · 2024-11-19T14:29:24Z

pkg/resources/configmap/configmap_test.go

+		// Check that the ConfigMap has the correct data
+		if foundConfigMap.Data["key"] != configMap.Data["key"] {
+			t.Errorf("ConfigMap has incorrect data: expected %s, got %s", configMap.Data["key"], foundConfigMap.Data["key"])
+		}


This works, but it is also redundant, since assert.Equals calls reflect.DeepEqual internally.

ChristianAtDell and others added 30 commits November 7, 2024 16:31

Coverage increased to 7.8 percent

a924f55

12.9 percent utils test coverage

ab18214

19.2 percent, removed StatefulSet dead code

205cee6

27.4 percent, plus some TODOs and code cleanup

305dcc9

29.4 percent + reusable client generator

be3325b

35.5 percent

021d68e

add UT for configmap.go

c0d8654

add UT for csidriver package

3764411

36.4 percent. Removed dead code from ank8s.

0504236

Coverage increased to 7.8 percent

4a9a5d7

12.9 percent utils test coverage

3a7980f

19.2 percent, removed StatefulSet dead code

9f579fa

27.4 percent, plus some TODOs and code cleanup

c06a502

29.4 percent + reusable client generator

1c5a55b

35.5 percent

194358c

add UT for configmap.go

bbf5d5e

add UT for csidriver package

2703380

36.4 percent. Removed dead code from ank8s.

4dd3329

Added unit tests for basic scenarios for getdeploymentstatus

db4b8bb

Merge branch 'pub/increase-utils-coverage' of https://github.com/dell…

3c6dff9

…/csm-operator into pub/increase-utils-coverage

Added tests for serviceaccount package

6ae44f9

Fix test name so it matches our current standard.

fc64369

salvaged some utils from pre-overwrite

cd37375

Merge branch 'pub/increase-utils-coverage' of https://github.com/dell…

c5ecc59

…/csm-operator into pub/increase-utils-coverage

add coverage for SyncDaemonset and update logging of errors for reada…

50e6adc

…bility

ignore error from logger

52ff935

unit test WaitForNginxController

b83d846

add not found test

383cc9b

Status unit tests for modules

0df6d65

Merge branch 'pub/increase-utils-coverage' of https://github.com/dell…

ec86b9c

…/csm-operator into pub/increase-utils-coverage