Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated nightly versions to CSM 1.12 image tags #768

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Updated nightly versions to CSM 1.12 image tags #768

merged 8 commits into from
Oct 30, 2024

Conversation

rajendraindukuri
Copy link
Collaborator

@rajendraindukuri rajendraindukuri commented Oct 30, 2024 •
edited by JacobGros
Loading

Description

  • Updated nightly versions to CSM 1.12 image tags in OperatorConfig folder

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Made sure all the unit tests are passing
  • E2E sanity and pflex tests run and passing. Results tracked internally.
  • ran unity e2e, results tracked internally
  • ran pscale e2e: nohup ./run-e2e-test.sh --pscale &, results tracked internally
  • ran pstore e2e: nohup ./run-e2e-test.sh --pstore &, results tracked internally
  • ran pmax e2e: nohup ./run-e2e-test.sh --pmax &, results tracked internally
  • ran auth v2 e2e w/ pflex to verify everything worked

@rajendraindukuri rajendraindukuri marked this pull request as ready for review October 30, 2024 12:23
@JacobGros
Copy link
Contributor

some of the images referenced in this PR aren't pushed yet; IMO it would make more sense to wait for every component to release first, and then we can run some e2e on this branch before merging this PR and releasing operator

@alexemc alexemc force-pushed the updating-nightly-to-release-versions-in-operator-config branch from f0d2b12 to fd5439a Compare October 30, 2024 16:29
@JacobGros JacobGros requested a review from anandrajak1 October 30, 2024 16:29
hoppea2
hoppea2 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jooseppi-luna
jooseppi-luna approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacobGros JacobGros merged commit f88f6b6 into main Oct 30, 2024
7 checks passed
@JacobGros JacobGros deleted the updating-nightly-to-release-versions-in-operator-config branch October 30, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell left review comments

@anandrajak1 anandrajak1 anandrajak1 approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@rajendraindukuri @JacobGros @jooseppi-luna @hoppea2 @anandrajak1 @AkshaySainiDell @santhoshatdell @anathoodell @alexemc @EvgenyUglov