Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of observability in minimal manifest for powermax #733

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

AkshaySainiDell
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 14, 2024

Description

Add support of observability in minimal manifest for powermax.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1449

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Ran PowerMax with Observability E2E metrics tests
image
image
image

@JacobGros
Copy link
Contributor

can we run all existing pmax e2e tests before merging this in?
Tests can run standalone now or should be able to run in sequence if using my branch https://github.com/dell/csm-operator/tree/fix-pmax-e2e

@AkshaySainiDell
Copy link
Contributor Author

can we run all existing pmax e2e tests before merging this in? Tests can run standalone now or should be able to run in sequence if using my branch https://github.com/dell/csm-operator/tree/fix-pmax-e2e

@JacobGros There will be a separate PR covering powermax e2e.

@AkshaySainiDell AkshaySainiDell merged commit 6e3d404 into main Oct 16, 2024
7 checks passed
@mjsdell mjsdell deleted the minimal-obs-pmax branch October 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants