Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Controller Runtime, SDK and k8s modules #707

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Update Controller Runtime, SDK and k8s modules #707

merged 6 commits into from
Sep 30, 2024

Conversation

HarishH-DELL
Copy link
Contributor

@HarishH-DELL HarishH-DELL commented Sep 26, 2024 •
edited by chimanjain
Loading

Description

Update Controller Runtime, SDK and k8s modules
Controller Runtime - v0.18.5
SDK - 1.37
K8s io modules - v0.30.5

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Go mod tidy
  • Basic image build using podman
  • Ran the unit test, results are:
go run core/semver/semver.go -f mk > semver.mk
go fmt ./...
core/core_generated.go
go vet ./...
KUBEBUILDER_ASSETS="/root/.local/share/kubebuilder-envtest/k8s/1.30.3-linux-amd64" go test ./... -coverprofile cover.out
        github.com/dell/csm-operator            coverage: 0.0% of statements
        github.com/dell/csm-operator/api/v1             coverage: 0.0% of statements
?       github.com/dell/csm-operator/pkg/constants      [no test files]
        github.com/dell/csm-operator/pkg/logger         coverage: 0.0% of statements
        github.com/dell/csm-operator/core/semver                coverage: 0.0% of statements
        github.com/dell/csm-operator/core               coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/csidriver            coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/configmap            coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/rbac         coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/serviceaccount               coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/deployment           coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/daemonset            coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/utils          coverage: 0.0% of statements
        github.com/dell/csm-operator/pkg/resources/statefulset          coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared               coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/crclient              coverage: 0.0% of statements
        github.com/dell/csm-operator/tests/shared/clientgoclient                coverage: 0.0% of statements
ok      github.com/dell/csm-operator/controllers        57.851s coverage: 88.8% of statements
ok      github.com/dell/csm-operator/k8s        0.161s  coverage: 83.9% of statements
ok      github.com/dell/csm-operator/pkg/drivers        0.349s  coverage: 95.2% of statements
ok      github.com/dell/csm-operator/pkg/modules        2.780s  coverage: 90.3% of statements

@HarishH-DELL HarishH-DELL changed the title Upd go module Update Controller Runtime, SDK and k8s modules Sep 26, 2024
@HarishH-DELL HarishH-DELL marked this pull request as ready for review September 30, 2024 09:56
chimanjain
chimanjain approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@chimanjain chimanjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarishH-DELL HarishH-DELL merged commit a35d5a0 into main Sep 30, 2024
7 checks passed
@chimanjain chimanjain deleted the upd-go-module branch October 3, 2024 05:43
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell @chimanjain
Update Controller Runtime, SDK and k8s modules (#707)
08f38fd 
* update k8s modules

* update gomega module and revert controller-runtime

* controller runtime update to 0.18.5

* opeartor sdk update

* fix lint issues

* update ENVTEST_K8S_VERSION to 1.30

---------

Co-authored-by: Chiman Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@chimanjain chimanjain chimanjain approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarishH-DELL @chimanjain @shefali-malhotra