Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change v1alpha1 to v1alpha2 #69

Merged
merged 4 commits into from
Apr 5, 2022
Merged

change v1alpha1 to v1alpha2 #69

merged 4 commits into from
Apr 5, 2022

Conversation

nb950
Copy link
Contributor

@nb950 nb950 commented Apr 1, 2022 •
edited
Loading

Description

change v1alpha1 to v1alpha2 in api and all files
not backward compatible
so please remove old csm / crd ,then install new crd create csm

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • manual run unit tests Ok
  • manual build deploy image Ok

@nb950 nb950 changed the title change v1alpha1 to v2alpha2 change v1alpha1 to v1alpha2 Apr 1, 2022
jooseppi-luna
jooseppi-luna approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nb950 nb950 merged commit 99789d2 into main Apr 5, 2022
@rensyct rensyct deleted the update-crd-v1alpha2 branch July 18, 2022 12:17
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
change v1alpha1 to v1alpha2 (#69)
e1d6943 
* change v1alpha1 to v2alpha2

* disable checks due to missing api/v1alpha2 in repo

* add v1aplha2 folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi16394 abhi16394 abhi16394 approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@medegw01 medegw01 Awaiting requested review from medegw01

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@yifeijin yifeijin Awaiting requested review from yifeijin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nb950 @jooseppi-luna @abhi16394