-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor change to clusterrole #63
Conversation
@abhi16394 Please update checklist items above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhi16394, please help understand why namespace is being added in operator.yaml? We had specifically removed namespace from the manifest to fix the warning message that was thrown when installing the operator
@rensyct can you change the script to work if namespace exists, this way we can deploy without scripts
We dont want to make any code changes now. We can discuss this (whether install script should create the namespace or should fail if it does not exist ) in the next meet and take it forward in the next release |
@abhi16394 - Can you help answer @rensyct question? Is this change absolutely necesary at this time, and if yes, will this create changes in other areas? What happens if we dont set the namespace? |
* Minor change to clusterrole * Update clusterrole.go * Update clusterrole.go * clusterole changes * Adding namespace kind * reverting back change
Description
removing the object from error statement
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration