Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to clusterrole #63

Merged
merged 6 commits into from
Mar 8, 2022
Merged

Minor change to clusterrole #63

merged 6 commits into from
Mar 8, 2022

Conversation

abhi16394
Copy link
Collaborator

@abhi16394 abhi16394 commented Mar 7, 2022

Description

removing the object from error statement

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

JacobGros
JacobGros previously approved these changes Mar 7, 2022
@bharathsreekanth
Copy link
Collaborator

@abhi16394 Please update checklist items above.

yifeijin
yifeijin previously approved these changes Mar 7, 2022
nb950
nb950 previously approved these changes Mar 7, 2022
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi16394, please help understand why namespace is being added in operator.yaml? We had specifically removed namespace from the manifest to fix the warning message that was thrown when installing the operator

@rensyct can you change the script to work if namespace exists, this way we can deploy without scripts

@rensyct
Copy link
Contributor

rensyct commented Mar 8, 2022

@abhi16394, please help understand why namespace is being added in operator.yaml? We had specifically removed namespace from the manifest to fix the warning message that was thrown when installing the operator

@rensyct can you change the script to work if namespace exists, this way we can deploy without scripts

We dont want to make any code changes now. We can discuss this (whether install script should create the namespace or should fail if it does not exist ) in the next meet and take it forward in the next release

@bharathsreekanth
Copy link
Collaborator

@abhi16394 - Can you help answer @rensyct question? Is this change absolutely necesary at this time, and if yes, will this create changes in other areas? What happens if we dont set the namespace?

tdawe
tdawe previously approved these changes Mar 8, 2022
deploy/operator.yaml Outdated Show resolved Hide resolved
@tdawe tdawe self-requested a review March 8, 2022 14:01
@tdawe tdawe dismissed their stale review March 8, 2022 14:01

added comment

@abhi16394 abhi16394 dismissed stale reviews from nb950 and yifeijin via ee7ec2d March 8, 2022 16:29
@abhi16394 abhi16394 merged commit 942f6c5 into main Mar 8, 2022
@abhi16394 abhi16394 deleted the clusterrole-change branch March 8, 2022 17:32
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Minor change to clusterrole

* Update clusterrole.go

* Update clusterrole.go

* clusterole changes

* Adding namespace kind

* reverting back change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants