Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minimal image #61

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Updated minimal image #61

merged 1 commit into from
Mar 4, 2022

Conversation

tdawe
Copy link
Collaborator

@tdawe tdawe commented Mar 4, 2022

Description

Updated minimal image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deployed PowerScale driver successfully
# kubectl get pods -n powerscale-driver-install
NAME                                                    READY   STATUS    RESTARTS      AGE
powerscale-driver-install-controller-56cffbc5b9-vvrm7   6/6     Running   1 (84m ago)   84m
powerscale-driver-install-node-sqmb6                    3/3     Running   1 (84m ago)   84m
powerscale-driver-install-node-zkhgm                    3/3     Running   2 (84m ago)   84m

@tdawe tdawe merged commit 1b48808 into main Mar 4, 2022
@tdawe tdawe deleted the update-image branch March 4, 2022 20:10
@@ -21,7 +21,7 @@ COPY tests/ tests/
# Build
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager main.go

FROM registry.access.redhat.com/ubi8/ubi-minimal@sha256:3aa3f379a81013bd3264faa0af87d201cdaa5981050d78c567b48fdfd5b38bb8
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.5-230.1645809059
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdawe , we should be using sha instead?

ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants