Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gosec fixes #60

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Gosec fixes #60

merged 4 commits into from
Mar 3, 2022

Conversation

nb950
Copy link
Contributor

@nb950 nb950 commented Mar 3, 2022 •
edited
Loading

Description

gosec issues fix, specifically G304 https://securego.io/docs/rules/g304.html
enable actions gosec check for all except tests folder
hardcode path to yaml files to make it safer for now ,
next release remove yamls files on disk and move to configmaps in k8s

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • manual deploy and install driver
  • unit test coverage run

@nb950 nb950 merged commit 41edf1a into main Mar 3, 2022
@nb950 nb950 deleted the gosec-fixes branch March 17, 2022 19:22
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Gosec fixes (#60)
4f5f08a 
* gosec issues fix, specifically G304 https://securego.io/docs/rules/g304.html
enable actions gosec check for all except tests

* fix yaml

* fix gosec error in semver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@yifeijin yifeijin yifeijin approved these changes

@tdawe tdawe tdawe approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@medegw01 medegw01 Awaiting requested review from medegw01

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nb950 @tdawe @yifeijin @bharathsreekanth