Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle error improvement #59

Merged
merged 3 commits into from
Mar 2, 2022
Merged

handle error improvement #59

merged 3 commits into from
Mar 2, 2022

Conversation

yifeijin
Copy link
Contributor

@yifeijin yifeijin commented Mar 2, 2022 •
edited
Loading

Description

This PR fixes a couple minor bugs.

  • In daemonset/deployment deletion, return error if fails
  • Check for not found error in more places
  • After csm obj gets finalizer added, continue instead of return
  • Fix unit tests for above changes

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Manually install and uninstall

abhi16394
abhi16394 previously approved these changes Mar 2, 2022
View reviewed changes
@gallacher
Copy link
Contributor

@yifeijin, Please complete the PR checklist in the description and outline the testing that was performed. Thank you!

@nb950 nb950 requested a review from abhi16394 March 2, 2022 20:25
@nb950 nb950 merged commit 63c2e6c into main Mar 2, 2022
@rensyct rensyct deleted the error_handle branch July 18, 2022 12:17
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
handle error improvement (#59)
2269fb2 
* handle error improvement

* fix logging but

* pass ctx to finalizeradd/move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@nb950 nb950 nb950 approved these changes

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@medegw01 medegw01 Awaiting requested review from medegw01

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yifeijin @gallacher @nb950 @abhi16394 @bharathsreekanth