-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct image field in the manifest #57
Conversation
deploy/operator.yaml
Outdated
@@ -436,7 +436,7 @@ spec: | |||
- --leader-elect | |||
command: | |||
- /manager | |||
image: controller:latest | |||
image: dellemc/dell-csm-operator:0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no such image in dockerhub dellemc , so why does it matter what we put here for now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would push the image to DockerHub close to the release date (RFD)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we wait until code-freeze to update the docker location?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All drivers and operator map the image to external repos as a standard practice. It also eases up the release process
This change can be related to myvalues.yaml of the helm installation - where we provide the repo and version values.
The value in this field is what gets reflected in the CSV and other manifests (used for OLM installation). Generating it with dellemc tag keeps it consistent across the various generated manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At code freeze the image won't be in DockerHub yet, so we can set it to point to DockerHub now and our install scripts allow us to override it to an internal artifactory location for our dev/testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image tag can be updated to v0.1.0 to be consistent with our naming scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this change. This is similar to what we did with the common installer so please proceed with the merge.
9aae0c6
aee46f0
to
7d24c55
Compare
7d24c55
to
521f76d
Compare
Description
This PR corrects the image field in the manifest which is used for install script
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration