Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct image field in the manifest #57

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Correct image field in the manifest #57

merged 1 commit into from
Mar 3, 2022

Conversation

rensyct
Copy link
Contributor

@rensyct rensyct commented Mar 2, 2022

Description

This PR corrects the image field in the manifest which is used for install script

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@@ -436,7 +436,7 @@ spec:
- --leader-elect
command:
- /manager
image: controller:latest
image: dellemc/dell-csm-operator:0.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no such image in dockerhub dellemc , so why does it matter what we put here for now ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok. To that point, when do we start to publish images on docker hub for the operator @rensyct @tdawe ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would push the image to DockerHub close to the release date (RFD)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wait until code-freeze to update the docker location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All drivers and operator map the image to external repos as a standard practice. It also eases up the release process
This change can be related to myvalues.yaml of the helm installation - where we provide the repo and version values.
The value in this field is what gets reflected in the CSV and other manifests (used for OLM installation). Generating it with dellemc tag keeps it consistent across the various generated manifests.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At code freeze the image won't be in DockerHub yet, so we can set it to point to DockerHub now and our install scripts allow us to override it to an internal artifactory location for our dev/testing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image tag can be updated to v0.1.0 to be consistent with our naming scheme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the version

gallacher
gallacher previously approved these changes Mar 2, 2022
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change. This is similar to what we did with the common installer so please proceed with the merge.

tdawe
tdawe previously approved these changes Mar 2, 2022
@rensyct rensyct dismissed stale reviews from bharathsreekanth, tdawe, and gallacher via 9aae0c6 March 3, 2022 07:53
@rensyct rensyct force-pushed the correct_image_field branch from aee46f0 to 7d24c55 Compare March 3, 2022 08:52
panigs7
panigs7 previously approved these changes Mar 3, 2022
tdawe
tdawe previously approved these changes Mar 3, 2022
@rensyct rensyct merged commit d00bb18 into main Mar 3, 2022
@rensyct rensyct deleted the correct_image_field branch March 21, 2022 09:16
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants