Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e test fix #55

Merged
merged 2 commits into from
Mar 3, 2022
Merged

E2e test fix #55

merged 2 commits into from
Mar 3, 2022

Conversation

medegw01
Copy link
Contributor

@medegw01 medegw01 commented Feb 28, 2022 •
edited by bharathsreekanth
Loading

Description

Update e2e script to point to new e2e package

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

gallacher
gallacher approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathsreekanth bharathsreekanth merged commit c6d9c47 into main Mar 3, 2022
@bharathsreekanth bharathsreekanth deleted the e2e-test-fix branch March 3, 2022 14:29
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
E2e test fix (#55)
1da7c0e 
* Update run-e2e-test.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher approved these changes

@jooseppi-luna jooseppi-luna jooseppi-luna approved these changes

@tdawe tdawe tdawe approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@nb950 nb950 Awaiting requested review from nb950

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@yifeijin yifeijin Awaiting requested review from yifeijin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@medegw01 @tdawe @jooseppi-luna @gallacher @bharathsreekanth